Removing createReactClass usage in 3 files. #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
catandthemachines
requested review from
jeremywiebe,
benchristel,
nishasy,
handeyeco and
anakaren-rojas
|
Size Change: -586 B (-0.05%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
jeremywiebe
requested changes
Nov 20, 2024
Comment on lines
51
to
53
| getInitialState() { | ||
| return {dragHover: false}; | ||
| }, | ||
| handleDrop: function (e) { | ||
| } |
There was a problem hiding this comment.
When initial state doesn't depend on anything, I typically avoid the function getInitialState() and just define state like this:
state: State = {dragHover: false};
benchristel
reviewed
Nov 20, 2024
benchristel
reviewed
Nov 20, 2024
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (9db2826) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1893If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1893 |
benchristel
reviewed
Nov 26, 2024
jeremywiebe
reviewed
Nov 27, 2024
Comment on lines
+23
to
+27
| * TODO(LEMS-2667): 11/26/24, at the time of writing this comment | ||
| * it has been identified that this file has been broken long before | ||
| * the refactoring of createReactClass. Future implementation need | ||
| * to determine how to fix this functionality or deprecate it. | ||
| * * |
There was a problem hiding this comment.
Nice, thanks for leaving this comment here.
jeremywiebe
reviewed
Nov 27, 2024
Comment on lines
179
to
181
| constructor(props) { | ||
| super(props); | ||
| } |
There was a problem hiding this comment.
When you are just calling super(props); in a constructor, you can elide it.
Suggested change
| constructor(props) { | |
| super(props); | |
| } |
jeremywiebe
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Removing createReactClass usage in the following three files:
Issue: LEMS-365
Test plan:
Run "yarn test" and confirm no errors or regressions are introduced.
Run "yarn start" and look and view if there are any issues with any Perseus components.